Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-core): refer absolute path of global types file #4924

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(language-core): refer absolute path of global types file #4924

wants to merge 2 commits into from
+20 −9

Conversation

depressedX
Copy link

fix #4860

Check the detail info here
#4860 (comment)

Solution

Change globalTypes reference to absolute path:

before:

/// <reference types=".vue-global-types/vue_3.4_false.d.ts" />

after:

/// <reference types="/absolute/path/to/.vue-global-types/vue_3.4_false.d.ts" />

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 15, 2024 •
edited
Loading

Open in Stackblitz

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4924

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4924

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4924

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4924

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4924

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4924

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4924

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4924

commit: df02fec

@depressedX
Copy link
Author

@KazariEX noticed you've fixed serveral issues about globalTypes. So could you help checking these changes?

@KazariEX
Copy link
Collaborator

Can we centralize the operations of obtaining path and writing data in the same function setupGlobalTypes?

@KazariEX KazariEX enabled auto-merge (squash) October 15, 2024 06:26
@KazariEX KazariEX changed the title fix(language-core): can not reference .vue-global-types/vue_3.4_false.d.ts in monorepo, causing vue-tsc error fix(language-core): refer absolute path of global types file Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazariEX KazariEX KazariEX approved these changes

@johnsoncodehk johnsoncodehk Awaiting requested review from johnsoncodehk johnsoncodehk is a code owner

@so1ve so1ve Awaiting requested review from so1ve so1ve is a code owner

@zhiyuanzmj zhiyuanzmj Awaiting requested review from zhiyuanzmj zhiyuanzmj is a code owner

@KermanX KermanX Awaiting requested review from KermanX KermanX is a code owner

@davidmatter davidmatter Awaiting requested review from davidmatter davidmatter is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error TS2688: Cannot find type definition file for '.vue-global-types/vue_3.5_false.d.ts'
2 participants
@depressedX @KazariEX