-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit figcaption styles #4241
Comments
I liked Patrick's suggestion of having a line/block to the left of both the image and the caption. So long as it isn't confused with blockquotes? If there's a page of WAI components somewhere it would be useful to see how it fits in with other styles. |
I can work on a speculative PR for this |
WAI's blockquote styles only ever include a leading border in instances where there is also a large quote mark in front of it: https://wai-website-theme.netlify.app/components/blockquotes/ |
Could we see a few different designs on the same page with the contents of the |
Possibly worth noting: the WAI design components site has a page on figures, but its only examples use |
had a little play with what I had in mind here https://codepen.io/patrickhlauke/pen/ogNwdGG
I think it looks good even without constraining the width, to be honest ... makes it less "messy" when a page includes different figures of varying width. |
Mentioned on backlog call 3/7. |
Thanks! I like all the choices you made. The figure caption text is easy to read, and the visual cues help associate text with figures but distinct from body text. I agree that there does not seem to be benefit from constraining the line width. |
Figcaptions are currently displayed in bold text, due to styles defined WAI-website-wide in
/WAI/assets/css/style.css
.This can perhaps be overwhelming for captions that run particularly long, and also limits options to emphasize content within those captions, as pointed out in #4055 (comment).
On the other hand, the existing bold styles do make it easy to distinguish figcaptions from ordinary paragraphs of text within the body.
Some thoughts that came up in discussion on the backlog TF call on 2025-02-21:
figure
+figcaption
to make the caption match the width of the image? (This may be possible with CSSinline-grid
+ figcaption width trickery)min-width
, since some figures are not very wide (e.g. Figure 4 in Non-text Contrast)WIP exploring options on my fork
Example before and (proposed) after:
The text was updated successfully, but these errors were encountered: