ci(lint): fix react/no-children-prop eslint violations

weaveworks · Jan 19, 2025 · 320c0a0 · 320c0a0
1 parent 714e125
commit 320c0a0
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 16 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -44,7 +44,6 @@ export default tseslint.config([
             "import/no-unresolved": 0,
 
             "react/display-name": 0,
-            "react/no-children-prop": 0,
             "react/prop-types": 0,
             "react-hooks/exhaustive-deps": 0,
             "react-hooks/rules-of-hooks": 0,

diff --git a/ui/components/InfoModal.tsx b/ui/components/InfoModal.tsx
@@ -50,8 +50,9 @@ function InfoModal({ searchedNamespaces, onCloseModal, open }: Props) {
       onClose={onClose}
       title="Searched namespaces"
       description="These are the namespaces that we've searched per cluster to retrieve the objects that you are seeing on this page."
-      children={content}
-    />
+    >
+      {content}
+    </Modal>
   );
 }
 

diff --git a/ui/components/Policies/PolicyDetails/PolicyDetails.tsx b/ui/components/Policies/PolicyDetails/PolicyDetails.tsx
@@ -103,13 +103,12 @@ const PolicyDetails = ({ policy }: Props) => {
         <Flex wide tall column gap="32">
           <HeaderRows items={items} />
           <SectionWrapper title="Description:">
-            <MarkdownEditor children={description || ""} />
+            <MarkdownEditor>{description || ""}</MarkdownEditor>
           </SectionWrapper>
           <SectionWrapper title="How to solve:">
-            <MarkdownEditor
-              children={howToSolve || ""}
-              remarkPlugins={[remarkGfm]}
-            />
+            <MarkdownEditor remarkPlugins={[remarkGfm]}>
+              {howToSolve || ""}
+            </MarkdownEditor>
           </SectionWrapper>
           <SectionWrapper title="Policy Code:">
             <YamlView type="rego" yaml={code} />

diff --git a/ui/components/Policies/PolicyViolations/PolicyViolationDetails.tsx b/ui/components/Policies/PolicyViolations/PolicyViolationDetails.tsx
@@ -112,13 +112,12 @@ export const ViolationDetails = ({
         </ul>
       </SectionWrapper>
       <SectionWrapper title="Description:">
-        <MarkdownEditor children={description || ""} />
+        <MarkdownEditor>{description || ""}</MarkdownEditor>
       </SectionWrapper>
       <SectionWrapper title="How to solve:">
-        <MarkdownEditor
-          children={howToSolve || ""}
-          remarkPlugins={[remarkGfm]}
-        />
+        <MarkdownEditor remarkPlugins={[remarkGfm]}>
+          {howToSolve || ""}
+        </MarkdownEditor>
       </SectionWrapper>
       <SectionWrapper title=" Parameters Values:">
         <Parameters parameters={parameters} />

diff --git a/ui/components/Sync/SuspendMessageModal.tsx b/ui/components/Sync/SuspendMessageModal.tsx
@@ -71,9 +71,10 @@ function SuspendMessageModal({
       onClose={onClose}
       title="Suspend Reason"
       description="Add reason for suspending"
-      children={content}
       className={className}
-    />
+    >
+      {content}
+    </Modal>
   );
 }
 

diff --git a/ui/contexts/GithubAuthContext.tsx b/ui/contexts/GithubAuthContext.tsx
@@ -26,5 +26,9 @@ export default function GithubAuthContextProvider({ children }: Props) {
       setDialogState({ ...dialogState, open, repoName }),
     setSuccess: () => setDialogState({ ...dialogState, success: true }),
   };
-  return <GithubAuthContext.Provider value={value} children={children} />;
+  return (
+    <GithubAuthContext.Provider value={value}>
+      {children}
+    </GithubAuthContext.Provider>
+  );
 }