ci(lint): enable @typescript-eslint/ban-ts-comment eslint rule

weaveworks · Jan 19, 2025 · 86e17a0 · 86e17a0
1 parent b573514
commit 86e17a0
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 8 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -36,7 +36,6 @@ export default tseslint.config([
                 }
             ],
             "@typescript-eslint/no-explicit-any": 0,
-            "@typescript-eslint/ban-ts-comment": 0,
             "import/no-named-as-default": 0,
             "@typescript-eslint/switch-exhaustiveness-check": [2,
                 {

diff --git a/ui/lib/__tests__/graph.test.ts b/ui/lib/__tests__/graph.test.ts
@@ -151,7 +151,6 @@ describe("graph lib", () => {
       };
 
       const objects2 = await getChildren(
-        // @ts-ignore
         newClient,
         app.name,
         app.namespace,
@@ -198,7 +197,6 @@ describe("graph lib", () => {
       };
 
       const objects2 = await getChildren(
-        // @ts-ignore
         newClient,
         app.name,
         app.namespace,

diff --git a/ui/lib/fonts.ts b/ui/lib/fonts.ts
@@ -1,12 +1,12 @@
 import { createGlobalStyle } from "styled-components";
 // Typescript will handle type-checking/linting for this file
-// @ts-ignore
+// @ts-expect-error TODO
 import ProximaNovaBold from "url:../fonts/ProximaNovaBold.otf";
-// @ts-ignore
+// @ts-expect-error TODO
 import ProximaNovaRegular from "url:../fonts/ProximaNovaRegular.otf";
-// @ts-ignore
+// @ts-expect-error TODO
 import ProximaNovaSemibold from "url:../fonts/ProximaNovaSemibold.otf";
-// @ts-ignore
+// @ts-expect-error TODO
 import robotomono from "url:../fonts/roboto-mono-regular.woff";
 
 const Fonts = createGlobalStyle`

diff --git a/ui/lib/test-utils.tsx b/ui/lib/test-utils.tsx
@@ -88,7 +88,7 @@ export function withContext(
   });
   const isElement = React.isValidElement(TestComponent);
   window.matchMedia = jest.fn();
-  //@ts-ignore
+  //@ts-expect-error TODO
   window.matchMedia.mockReturnValue({ matches: false });
   return (
     <Router location={url} navigator={history}>