ci(lint): enable prealloc linter

.golangci.yaml

@@ -25,7 +25,7 @@ linters:
     - loggercheck
     - misspell
     - nolintlint
-    #- prealloc
+    - prealloc
     - staticcheck
     - stylecheck
     - tenv

core/clustersmngr/client.go

@@ -80,9 +80,9 @@ func (cle *ClusteredListError) Add(err ListError) {
 }
 
 func (cle ClusteredListError) Error() string {
-	var errs []string
-	for _, e := range cle.Errors {
-		errs = append(errs, e.Error())
+	errs := make([]string, len(cle.Errors))
+	for i, e := range cle.Errors {
+		errs[i] = e.Error()
 	}
 
 	return strings.Join(errs, "; ")

core/fluxsync/adapters.go

@@ -307,13 +307,13 @@ func (obj UnstructuredAdapter) GetConditions() []metav1.Condition {
 		return nil
 	}
 
-	var conditions []metav1.Condition
-	for _, c := range conditionsSlice {
+	conditions := make([]metav1.Condition, len(conditionsSlice))
+	for i, c := range conditionsSlice {
 		var condition metav1.Condition
 		if err := runtime.DefaultUnstructuredConverter.FromUnstructured(c.(map[string]interface{}), &condition); err != nil {
 			continue
 		}
-		conditions = append(conditions, condition)
+		conditions[i] = condition
 	}
 
 	return conditions

core/server/policies.go

@@ -103,15 +103,15 @@ func policyToPolicyRespone(policyCRD pacv2beta2.Policy, clusterName string) (*pb
 		HowToSolve:  policySpec.HowToSolve,
 	}
 
-	var policyLabels []*pb.PolicyTargetLabel
+	policyLabels := make([]*pb.PolicyTargetLabel, len(policySpec.Targets.Labels))
 	for i := range policySpec.Targets.Labels {
-		policyLabels = append(policyLabels, &pb.PolicyTargetLabel{
+		policyLabels[i] = &pb.PolicyTargetLabel{
 			Values: policySpec.Targets.Labels[i],
-		})
+		}
 	}
 
-	var policyParams []*pb.PolicyParam
-	for _, param := range policySpec.Parameters {
+	policyParams := make([]*pb.PolicyParam, len(policySpec.Parameters))
+	for i, param := range policySpec.Parameters {
 		policyParam := &pb.PolicyParam{
 			Name:     param.Name,
 			Required: param.Required,
@@ -122,14 +122,14 @@ func policyToPolicyRespone(policyCRD pacv2beta2.Policy, clusterName string) (*pb
 			return nil, err
 		}
 		policyParam.Value = value
-		policyParams = append(policyParams, policyParam)
+		policyParams[i] = policyParam
 	}
-	var policyStandards []*pb.PolicyStandard
-	for _, standard := range policySpec.Standards {
-		policyStandards = append(policyStandards, &pb.PolicyStandard{
+	policyStandards := make([]*pb.PolicyStandard, len(policySpec.Standards))
+	for i, standard := range policySpec.Standards {
+		policyStandards[i] = &pb.PolicyStandard{
 			Id:       standard.ID,
 			Controls: standard.Controls,
-		})
+		}
 	}
 
 	policy.Targets = &pb.PolicyTargets{

core/server/policy_violations.go

@@ -249,7 +249,7 @@ func getPolicyValidationParam(raw []byte) ([]*pb.PolicyValidationParam, error) {
 		return nil, fmt.Errorf("failed to unmarshal policy validation parameter, error: %v", err)
 	}
 
-	var parameters []*pb.PolicyValidationParam
+	parameters := make([]*pb.PolicyValidationParam, len(paramsArr))
 	for i := range paramsArr {
 		param := pb.PolicyValidationParam{
 			Name:     paramsArr[i]["name"].(string),
@@ -266,7 +266,7 @@ func getPolicyValidationParam(raw []byte) ([]*pb.PolicyValidationParam, error) {
 			return nil, err
 		}
 		param.Value = val
-		parameters = append(parameters, &param)
+		parameters[i] = &param
 	}
 	return parameters, nil
 }

core/server/session_logs.go

@@ -5,7 +5,9 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
+	"maps"
 	"regexp"
+	"slices"
 	"sort"
 	"strconv"
 	"strings"
@@ -346,12 +348,7 @@ func getPodLogs(ctx context.Context, nextToken string, minioClient s3Reader, buc
 		lastToken = obj.Key
 	}
 
-	var logSources []string
-	for k := range tmpLogSources {
-		logSources = append(logSources, k)
-	}
-	sort.Strings(logSources)
-
+	logSources := slices.Sorted(maps.Keys(tmpLogSources))
 	return logs, lastToken, logSources, nil
 }
 

pkg/sourceignore/sourceignore.go

@@ -6,6 +6,7 @@ import (
 	"io"
 	"os"
 	"path/filepath"
+	"slices"
 	"strings"
 
 	"github.com/go-git/go-git/v5/plumbing/format/gitignore"
@@ -31,20 +32,24 @@ type IgnoreFilter func(p string, fi os.FileInfo) bool
 // VCSPatterns returns a gitignore.Pattern slice with ExcludeVCS
 // patterns.
 func VCSPatterns(domain []string) []gitignore.Pattern {
-	var ps []gitignore.Pattern
-	for _, p := range strings.Split(ExcludeVCS, ",") {
-		ps = append(ps, gitignore.ParsePattern(p, domain))
+	all := strings.Split(ExcludeVCS, ",")
+	ps := make([]gitignore.Pattern, len(all))
+	for i, p := range all {
+		ps[i] = gitignore.ParsePattern(p, domain)
 	}
 	return ps
 }
 
 // DefaultPatterns returns a gitignore.Pattern slice with the default
 // ExcludeCI, ExcludeExtra patterns.
 func DefaultPatterns(domain []string) []gitignore.Pattern {
-	all := strings.Join([]string{ExcludeCI, ExcludeExtra}, ",")
-	var ps []gitignore.Pattern
-	for _, p := range strings.Split(all, ",") {
-		ps = append(ps, gitignore.ParsePattern(p, domain))
+	all := slices.Concat(
+		strings.Split(ExcludeCI, ","),
+		strings.Split(ExcludeExtra, ","),
+	)
+	ps := make([]gitignore.Pattern, len(all))
+	for i, p := range all {
+		ps[i] = gitignore.ParsePattern(p, domain)
 	}
 	return ps
 }