Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update references to deprecated Flux APIs #4502

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Jan 12, 2025

Closes

What changed?

Updated all references to Flux APIs to use non-deprecated versions.

Why was this change made?

While running some Go tests, I noticed some warnings about the use of deprecated Flux API versions. While fixing this, I noticed a lot of outdated references in both UI and docs. We should avoid referring to deprecated Flux API versions.

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@erikgb erikgb requested a review from casibbald January 12, 2025 23:10
@erikgb erikgb marked this pull request as ready for review January 12, 2025 23:10
@erikgb erikgb force-pushed the fix-deprecated-api branch from 0a21768 to e639353 Compare January 13, 2025 07:41
@erikgb erikgb marked this pull request as draft January 13, 2025 07:47
@erikgb erikgb force-pushed the fix-deprecated-api branch from e639353 to 2aff03a Compare January 13, 2025 07:52
@erikgb erikgb marked this pull request as ready for review January 13, 2025 07:52
@casibbald
Copy link
Collaborator

We need to only update Docs related to our next release.

@erikgb erikgb force-pushed the fix-deprecated-api branch 2 times, most recently from bfe84b6 to c7c6081 Compare January 13, 2025 11:07
@erikgb erikgb enabled auto-merge (rebase) January 13, 2025 22:23
@erikgb erikgb force-pushed the fix-deprecated-api branch from c7c6081 to 39cdbbd Compare January 13, 2025 22:23
@erikgb erikgb disabled auto-merge January 14, 2025 10:15
@erikgb erikgb enabled auto-merge (rebase) January 14, 2025 10:15
@erikgb erikgb force-pushed the fix-deprecated-api branch from 6d677f2 to 9ff7433 Compare January 14, 2025 12:30
@erikgb
Copy link
Contributor Author

erikgb commented Jan 14, 2025

We need to only update Docs related to our next release.

This has been addressed now, @casibbald. PTAL! 🙏

@erikgb erikgb merged commit 82d760e into weaveworks:main Jan 14, 2025
15 checks passed
This was referenced Jan 15, 2025
This was referenced Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants