Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shim): use module.require to avoid variable collision #282

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Oct 12, 2024

Summary

Fix #274, again 😅.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Oct 12, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit ec6d5d9
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/670a0f20a318cd000833d7d7
😎 Deploy Preview https://deploy-preview-282--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Oct 12, 2024

CodSpeed Performance Report

Merging #282 will improve performances by ×2.1

Comparing shimmmmm (ec6d5d9) with main (8c95826)

Summary

⚡ 1 improvements
✅ 2 untouched benchmarks

Benchmarks breakdown

Benchmark main shimmmmm Change
examples/react-component-bundle-false 365.8 ms 170.3 ms ×2.1

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works 👍

Screenshot 2024-10-12 at 14 04 40

@fi3ework fi3ework merged commit 876690b into main Oct 12, 2024
20 checks passed
@fi3ework fi3ework deleted the shimmmmm branch October 12, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incorrect import.meta.url shim for CJS
2 participants