Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(deps): replace fast-glob with tinyglobby #307

Merged
merged 3 commits into from
Oct 18, 2024
Merged

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Oct 18, 2024

Summary

Tinyglobby is a fast and minimal alternative to globby and fast-glob, it is used by tsup, Vite and Nuxt.

  • tinyglobby is now in dependencies of @rslib/core because rsbuild-plugin-dts also depends on it. If we prebundle it, there will be two copies of the code.
  • Add absolute: true because fast-glob and tinyglobby use different relative formats, fast-glob will return ./path/to/file.js, tinyglobby will return path/to/file.js. Also the absolute path is more friendly to the Node fs APIs.

This PR should reduce 15 sub-dependencies of Rslib:

image

Related Links

https://github.com/SuperchupuDev/tinyglobby?tab=readme-ov-file#api

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan chenjiahan marked this pull request as draft October 18, 2024 08:06
Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 7154e58
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/67121718b41c660008d4ae9f
😎 Deploy Preview https://deploy-preview-307--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Oct 18, 2024

CodSpeed Performance Report

Merging #307 will improve performances by 68.85%

Comparing tinyglobby_1018 (5dd1513) with main (760968b)

Summary

⚡ 1 improvements
✅ 3 untouched benchmarks

Benchmarks breakdown

Benchmark main tinyglobby_1018 Change
examples/react-component-bundle-false 298.2 ms 176.6 ms +68.85%

@chenjiahan chenjiahan marked this pull request as ready for review October 18, 2024 08:33
@Timeless0911
Copy link
Collaborator

We also prebundled picocolors which is used by both @rslib/core and rsbuild-plugin-dts, is that two copies of picocolors breaks? picocolors should be a tiny size package.

@fi3ework fi3ework merged commit 77ed962 into main Oct 18, 2024
21 checks passed
@fi3ework fi3ework deleted the tinyglobby_1018 branch October 18, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants