Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: add package on conda-forge #105

Closed
luk-f-a opened this issue May 21, 2023 · 4 comments
Closed

feature request: add package on conda-forge #105

luk-f-a opened this issue May 21, 2023 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@luk-f-a
Copy link

luk-f-a commented May 21, 2023

hi devs, great project, I'm a heavy user of ipyvuetify and I really like the concept behind solara. I had a problem when I wanted to test it: there's no package on conda-forge (that I could find, at least).

I know that it's possible to use pip in a conda environment, which I did, but the large number of dependencies became a problem, because pip and conda don't play together very well in dependency resolution. pip attempted to update and reinstall many already-present packages.

Anyway, something to consider for the future. Thanks for your work!

@maartenbreddels maartenbreddels added the help wanted Extra attention is needed label May 22, 2023
@maartenbreddels
Copy link
Contributor

Ouch, I typed a whole reply, and I lost it :).

Short version:

We currently have a very smooth release process, and in my experience conda-forge adds a lot of friction for releasing, especially with two interdependent packages (solara and solara-assets).

But if we can have a conda-forge recipe that releases both solara and solara-assets in 1 PR, and if we can open that PR from https://github.com/widgetti/solara/blob/master/.github/workflows/release.yaml I'm good with it. Then in principle releasing is just clicking a merge button on conda-forge.

If someone wants to set that up, I'm in favor.

@giswqs
Copy link
Contributor

giswqs commented May 27, 2023

I have submitted a PR to add solara and solara-assets to conda-forge (conda-forge/staged-recipes#22935). Once the recipes have been accepted, I can add more maintainers. We can set up a bot automerge, which can automatically create PR based on PyPI releases. We only need to manually update the conda-forge recipe if the dependency list of the PyPI package has changed.

@giswqs
Copy link
Contributor

giswqs commented May 27, 2023

@maartenbreddels Can you merge the PR (conda-forge/ipyvuetify-feedstock#39) to update ipyvuetify to v1.8.10? Solara requires ipyvuetify >=1.8.10.

@iisakkirotko
Copy link
Collaborator

Closing this as done by conda-forge/staged-recipes#23413. The recipe can be found at https://github.com/conda-forge/solara-feedstock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants