Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Manifest v3 #213

Closed
GeoNomad opened this issue Mar 25, 2022 · 3 comments
Closed

[FEAT] Manifest v3 #213

GeoNomad opened this issue Mar 25, 2022 · 3 comments
Assignees
Labels
feature A new feature

Comments

@GeoNomad
Copy link

I have noticed that installing from the files brings up a warning that the manifest file is version 2 and that this will be deprecated next year.

A quick look at the documentation makes it look like this is more than a need to just replace the file as background pages will be replaced by service workers.

Being new to extensions, I am not sure how big an issue that is.

But I don't want to spend too much time modifying the code to find that a major change will be required later. I have been working on a cloud sync to use Read Later from Chrome on my phone, which is working great.

Will/Can you update to v3?

@GeoNomad GeoNomad added the feature A new feature label Mar 25, 2022
@willbchang
Copy link
Owner

willbchang commented Mar 26, 2022

Hi Peter, thanks for reminding. I think the upgrade doesn't affect the functionalities, hence I will finish this in my spare time before being deprecated. I might be busy on work for a month, but the upgrade won't be long. 😄

I have been working on a cloud sync to use Read Later from Chrome on my phone, which is working great.

Sounds great! Your work may fix #139. Can you share the idea with explanation or open source the code?

@GeoNomad
Copy link
Author

Thank you for the response, Will.

Yes, I will open source the code when I am a little further along. At this point, the sync only works one way - I just added jQuery.post('https://....com/....php', id=${page.date}&url=${page.url}); in set(page) in chrome/storage.mjs.
And jQuery.post('https://....com/....php', remove=${url}); to remove(url).

The rest is php to display the list and keep my private history list. I am looking at how to feed items that have been read back to the extension. A better way would be to add a new sync to updateStorage and use removeDeletePages, I guess.

For now it is just for my own use, anyway.

@willbchang
Copy link
Owner

Hi @GeoNomad

It's been a busy year at work and life. Finally I got time to upgrade this extension to manifest 3. The code has been merged to master at #215, all the main changes that needs to be aware are listed in the pr. Feel free to update your code base on the master branch. I'm happy to answer any question. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

No branches or pull requests

2 participants