Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting NaN Values has strange behaviour #31

Open
phectori opened this issue Mar 9, 2020 · 3 comments
Open

Plotting NaN Values has strange behaviour #31

phectori opened this issue Mar 9, 2020 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@phectori
Copy link
Contributor

phectori commented Mar 9, 2020

There you go!

Screenshot_20200309_164416

@windelbouwman
Copy link
Owner

What type of behavior do you expect?

Options:

  • Drop all NaN values
  • other ideas?

@windelbouwman windelbouwman added good first issue Good for newcomers help wanted Extra attention is needed bug Something isn't working labels Mar 9, 2020
@phectori
Copy link
Contributor Author

phectori commented Mar 9, 2020

I would say: Do not draw a line between the points surrounding the NaN value, or maybe ignore it completely.

It depends whether you want to indicate a NaN value has been sent. You could also give the line between the surrounding points a "warning" colour.

@windelbouwman
Copy link
Owner

The simplest implementation would be to ignore the value.

This might well be different from the right thing to do. In any case, I propose to drop the value with an warning in the logging. The person sending the data should check on NaN values I assume?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants