Astro 5.4 breaks custom Image Services

[amxmln]

Astro Info

Astro                    v5.4.0
Node                     v22.13.0
System                   macOS (arm64)
Package Manager          npm
Output                   static
Adapter                  none
Integrations             client:if
                         @astrojs/vue

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

After the upgrade to Astro 5.4, builds no longer work if they are using a custom image service which relied upon isRemoteAllowed because the export was moved to a different file.

It used to be exported as part of the astro/assets/utils package, but now seems to reside under @astrojs/internal-helpers/remote, which suggests it is no longer part of a public API.

This is a breaking change (even though for a limited amount of users) and should at least be documented if it was intentional.

Thanks for keeping up the great work on Astro!

What's the expected result?

Custom image services should keep working without changes.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-txiuvwma?file=integrations/custom-image-service.js&on=stackblitz

Participation

• I am willing to submit a pull request for this issue.

[florian-lefebvre]

isRemoteAllowed is not documented in our docs so I'm not sure we can consider it a public API before 5.4 actually. @Princesseuh what do you think?

[Princesseuh]

I'm almost sure I wrote a README somewhere to explain that they're exported, not sure where though as I can't find it now. But yes, the files in that folder were purposely exported for other services to use!

[amxmln]

The docs suggest that custom image services should be based on the provided image services, hence why I assumed that all the properties used in those would be public API. They are also listed as exports in Astro’s package.json.

I feel like I had also read about them in a README or the docs when I first built this service, but I can’t find any reference anymore either.

[ematipico]

@amxmln can you please test this preview? #13336 (comment)

Let us know if it fixes your issue

[amxmln]

@ematipico thanks for looking at this so quickly!

I can confirm that installing the preview package fixes the build, however, Vite now spits out the following warning, which didn’t happen before:

[WARN] [vite] "matchHostname", "matchPort", "matchPathname", "matchProtocol" and "matchPattern" are imported from external module "@astrojs/internal-helpers/remote" but never used in "node_modules/astro/dist/assets/services/service.js" and "node_modules/astro/dist/assets/utils/remotePattern.js".

[ematipico]

I think it's expected because @astrojs/internal-helpers wasn't published with the preview release.

On Monday we will release the patch, so the warning shouldn't be there. If there is, feel free to re-open the issue