Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tip from unclaimed rewards #84

Closed
alexkeating opened this issue Dec 11, 2024 · 1 comment · Fixed by #87
Closed

Remove tip from unclaimed rewards #84

alexkeating opened this issue Dec 11, 2024 · 1 comment · Fixed by #87
Assignees
@alexkeating
Labels
post-audit

Comments

@alexkeating
Copy link
Collaborator

Description

  • Withing bump earning power we should add
    // Send tip to the receiver
    SafeERC20.safeTransfer(REWARD_TOKEN, _tipReceiver, _requestedTip);
+   deposit.scaledUnclaimedRewardCheckpoint =
+      deposit.scaledUnclaimedRewardCheckpoint - (_requestedTip * SCALE_FACTOR);
@alexkeating
Copy link
Collaborator Author

sherlock-audit/2024-11-tally#33

@alexkeating alexkeating self-assigned this Dec 12, 2024
@alexkeating alexkeating mentioned this issue Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexkeating alexkeating

Labels
post-audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Subtract unclaimed rewards withtally/staker
1 participant
@alexkeating