At this point, I'm not sure that the whole .distignore file reading logic is working correctly.

I see the PR and discussion around gitignore-checker library update to 1.0.4. And in its tests I see rules that do not work here with the latest version of dist-archive.

For, example, if I include the /build/ line in my .distignore - this directory (although empty) is still included in the resulting zip.

But .git and .github directories are never included, for some reason.

The problem is not with the ignore logic, but the force param doesn‘t exactly do what you might think.

Previously, if the ZIP file already existed, you would get a prompt to overwrite it. If selecting no, the command would exit. Otherwise it rund the zip command. The force param simply skips that prompt.

The problem: if you run the zip program and the destination file already exists, it simply adds new files to it and it doesn‘t delete old ones.

I think we need to pass the -FS (filesync) argument to the zip command, see https://linux.die.net/man/1/zip

This, or just drop the zip file before creating a new one if --force is set.
wp dist-archive is running long enough on a small plugin anyways, so no one will even notice that speed difference.

I prefer simply passing an argument for a speed gain :-)

#108 should fix this, if you wanna give it a try.

@swissspidy I found this doc to checkout locally everything, but I don't understand how to run a global wp dist-archive command from a code inside my checked out dir.
Could you please help me understand that?

Also, I tried running composer behat, from here, but got this:

> run-behat-tests
ERROR 2002 (HY000): Can't connect to local MySQL server through socket '/tmp/mysql.sock' (2)
Script run-behat-tests handling the behat event returned with error code 1

I'm using valet, and TablePlus to manage users, and MySQL 8, and PHP 8.2 as my default PHP version.

If you check out only this repository and run wp dist-archive in that directory, it should actually use the version from the checkout. Alternatively, vendor/bin/wp should work also.

If you want to run composer behat, you first need to run composer prepare-tests to set up the database. Alternatively you can run with WP_CLI_TEST_DBTYPE=sqlite composer behat to run without MySQL setup. That should work fine in this case.

I tried composer prepare-tests, but it failed as well, as it needs to connect to MySQL from a socket file. I already created db, user, etc, so I don't think this is even needed. Thanks for the sqlite tip.

Trying to figure out how to run the command from the branch while zip'ing a plugin located elsewhere :)