Only use version from plugin header. #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
changed the title
It was already 7.4 elsewhere
"Broken symlink at {$relative_filepath}. Target missing at {$item->getLinkTarget()}."
BrianHenryIE
force-pushed
the
Uses-version-from-plugin-header-when-multiple-versions-are-present
branch
from
529293a to
1c1e5bb
Compare
swissspidy
reviewed
Jul 12, 2024
| @@ -0,0 +1,119 @@ | |||
| <?php | |||
|
|
|||
| class Version_Tool { | |||
There was a problem hiding this comment.
Related, similar code in i18n-command:
Maybe we can reuse some of that?
|
Yes! it happens to me sometimes that it gets the first PHP in the folder and it does not get the Plugin name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum definition for a plugin file says its set of headers must have the
Plugin Nameheader. This PR changes the version parsing code to only consider a parsed version if it is part of a PHP file's plugin headers, by checking does the "Plugin Name" header exist first.Previously, it was considering any
@versionin any PHP docblock.Fixes #92
Edit: looks like I didn't start the branch off upstream/master. I'll rewrite it soon.