Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request #5

Open
BenHildebrand opened this issue May 31, 2017 · 3 comments
Open

Feature Request #5

BenHildebrand opened this issue May 31, 2017 · 3 comments

Comments

@BenHildebrand
Copy link

Could you add a driver for the TLC59711? It looks like the only difference is the number of channels and bits, but I can't get the existing one working for it since I'm not familiar with python

@wrobell
Copy link
Owner

wrobell commented Jun 12, 2017

If that's the only difference then changing

BITS_PER_VALUE = 12
N_LEDS = 24

in fpulse/driver/tlc5947.py should be more than enough.

Unfortunately, I do not have such device.

What did you try to do? What errors do you have if any?

@BenHildebrand
Copy link
Author

BenHildebrand commented Jun 12, 2017

I changed that section to

BITS_PER_VALUE = 16
N_LEDS = 12

And testing with conf/morse.conf I get
binascii.Error: Odd-length string in _convert
data = unhexlify(s)

@wrobell
Copy link
Owner

wrobell commented Jul 5, 2017

Sorry for late response.

Before data = unhexlify(s), there is a line

        s = ''.join('{:03x}'.format(v) for v in reversed(values))

Can you try to change it to

        s = ''.join('{:04x}'.format(v) for v in reversed(values))

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants