Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bags in system. #2

Open
AndriiSvorak opened this issue Nov 4, 2015 · 0 comments
Open

Bags in system. #2

AndriiSvorak opened this issue Nov 4, 2015 · 0 comments

Comments

@AndriiSvorak
Copy link

You converter have 2 bags.

  1. In file vendor/xemle/html5-video-php/src/Html5Video/Html5Video.php:148, function does not work correctly. For example, I have current version 2.0.0, and second parameter was set as static 0.8, this function return FALSE (must return TRUE).
    I fixed this as next code:
    protected function isVersionIsGreaterOrEqual($version, $other) {
    $max = min(count($version), count($other));
    for ($i = 0; $i < $max; $i++) {
    if ($version[$i] < $other[$i]) {
    return false;
    } elseif ($version[$i] > $other[$i]) {
    return true;
    }
    }
    return true;
    }

  2. In file vendor/xemle/html5-video-php/src/Html5Video/Html5Video.php:226 or 230, function can't return array (if for example variable $targetConfig['videoEncoder'] have array('vpx', 'vp8')). Laravel 5.1 show error.

Please fix it.
Thank you.

@AndriiSvorak AndriiSvorak changed the title Hi. Bags in system. Nov 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant