Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename isConfigured() method in Service.hpp to allRegistersValid() #7

Open
ClemensElflein opened this issue Jan 21, 2025 · 1 comment

Comments

@ClemensElflein
Copy link
Member

ClemensElflein commented Jan 21, 2025

isConfigured() is misleading in the sense that it will return true BEFORE calling Configure(), because it just tracks if the registers are set (so that we can make sure at Configure() time, the registers are valid)

@rovo89
Copy link
Collaborator

rovo89 commented Feb 2, 2025

Similarly, Configure() is actually more a CheckConfiguration(). All examples I've seen so far looked at the values of registers and returned false if they're e.g. out of bounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants