-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"@typescript-eslint/eslint-plugin" and "@typescript-eslint/parser" fail to resolve with yarn versions >= 3.0.0 #5175
Comments
@NickLediet I'd say those are typos, which entered the stage in this PR #4612 (commit: 859c9ec) Interesting, that yarn on an older version would let this pass, as far as I understand semver rules, leading zero should not be allowed to not mess up version sorting. My guess is, that the newer yarn package fixed that, while we did not spot the typo due to still being on older yarn. |
We have only ever supported yarn v1. As I understand it yarn v2 changed things dramatically and yarn v3 reverted a lot of those changes? Regardless I think we should move back to npm at this point duplicate of #5245 |
I don't mind either way, but in the event someone would find the issue and get the wrong impression -
No, we didn't (or at least not the way you mean 😄). Modern releases of Yarn are far more stable than 1.x ever was, and you have the choice between installing your project using Performance-wise Yarn is still consistently faster than npm, and generally on par with pnpm.
We didn't either. The only "revert" we did (in v4, I believe) was to make the cache global by default rather than local, as it's what most projects would expect. But it was a fairly small change, just a matter of removing a little bit of friction - it has always been possible to configure Yarn far more than npm ever allowed. |
@arcanis thanks for clarifying the history, I might have some of it wrong as I'm mostly just spouting from memory what I've read, not experienced. I remember people complaining about yarn v2 introducing incompatibilities so it wasn't just a straight upgrade. That scared me off ever trying to upgrade tbh. For us it's more about yarn adds unnecessary complexity that npm handles just fine (more dependencies for devs to install, configure in CI, etc.). We're not using any special features and while yarn might be faster, modern npm which comes with node is definitely fast enough. Same reason I wouldn't want us to use pnpm either. |
I was following the "Running the demo" section of the contribution page in the wiki and came across the following error when running
yarn
to install the dependencies:I noticed the extra
0
on the end of the semver and figured that was the culprit. It also appeared that@typescript-eslint/parser
also had an extra0
on the end of the semver.I retried running
yarn
at version1.22.22
like the CI and it resolved the dependencies without any issues.I tested various major and minor releases of
yarn
and it appears the issue is replicated on all versions>= 3.0.0
.I wanted to confirm that the additional
0
at the end of the semver was not intentional before opening a PR to address it.Details
Steps to reproduce
3.0.0
or greater (or use a version manager for this, I'm using voltayarn cache clean
rm -rf node_modules
yarn
(orvolta run --yarn 3.0.0 yarn
)The text was updated successfully, but these errors were encountered: