Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leptos 0.7 upgradation #544

Open
harshita-srivastava-yral opened this issue Dec 4, 2024 · 11 comments
Open

Leptos 0.7 upgradation #544

harshita-srivastava-yral opened this issue Dec 4, 2024 · 11 comments
Assignees

Comments

@harshita-srivastava-yral
Copy link
Contributor

harshita-srivastava-yral commented Dec 4, 2024

Leptos thread: leptos-rs/leptos#3489

@harshita-srivastava-yral
Copy link
Contributor Author

  • 70% of the work is done on this
  • We need to benchmark the performance Pre- post the upgradation is done

@harshita-srivastava-yral
Copy link
Contributor Author

  • We will be done with this today

@harshita-srivastava-yral
Copy link
Contributor Author

  • Migrate the code to non-knightly rust compiler
  • Code is compatible to 0.7 however compiler is stuck

@harshita-srivastava-yral
Copy link
Contributor Author

  • Postponing it for now as we are not able to make progress from our end

@harshita-srivastava-yral
Copy link
Contributor Author

@siyara-m-yral to setup call with Saikat to understand the leptos issues and next steps

@siyara-m-yral
Copy link

  • We need to upgrade to 0.7 for hydration issues
  • However 0.7 has dynamic dispatch for nesting which has significantly increased the compile time(from seconds to minutes)

Next steps:

  1. Create issue in Leptos repo and see what they say
  2. Provide a branch to them so that they can reproduce the issue

@harshita-srivastava-yral
Copy link
Contributor Author

  • Having minimal code to reproduce the compiliation issue
  • The snippets are ready for the same

@siyara-m-yral
Copy link

  • To create an issue in Leptos - Need to come up with repr for SSR, for some reason the repr gists i had, turned out to work on SSR but not on CSR

@harshita-srivastava-yral
Copy link
Contributor Author

harshita-srivastava-yral commented Jan 22, 2025

  • Not able to find ways to generate big types and its working on SSR but on CSR
  • Actionable for @joel-medicala-yral
  1. Take the screenshot where compiler is throwing error and share with the leptos team
  2. Summary of things we have tried to fix this

@siyara-m-yral
Copy link

  • Created issue in Leptos repository, waiting on response

@harshita-srivastava-yral
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants