From fb57e9e2025652cfa9ef1f532ba44f2bf69e0807 Mon Sep 17 00:00:00 2001 From: Yohei Yukawa Date: Sun, 13 Oct 2024 17:06:39 -0700 Subject: [PATCH] Fix #1077: Deprecate `Mozc_tsf_ui.log` This commit affects only mozc_tip{32,64}.dll build with debug mode. There must be no behavior change in release build. Currently 'Mozc_tsf_ui.log' is created only when NDEBUG is defined. With this commit we stop creating it even when NDEBUG is defined. This addresses a crash issue in debug builds discussed in #1077. See #856 about why absl::LocalTimeZone cannot be used in Windows right now. Note that this commit may also help us diagnose #1076, where Windows.Storage.OneCore.dll looks to be intercepting certain Win32 file I/O API calls in AppContainer processes then trigger RoInitialize as needed. Creating 'Mozc_tsf_ui.log' only in debug builds can make our debugging more complicated. --- src/win32/tip/tip_text_service.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/win32/tip/tip_text_service.cc b/src/win32/tip/tip_text_service.cc index 3b363d69ec..98c48aecc0 100644 --- a/src/win32/tip/tip_text_service.cc +++ b/src/win32/tip/tip_text_service.cc @@ -511,8 +511,6 @@ class TipTextServiceImpl StorePointerForCurrentThread(this); HRESULT result = E_UNEXPECTED; - RegisterLogFileSink( - FileUtil::JoinPath(SystemUtil::GetLoggingDirectory(), kLogFileName)); EnsureKanaLockUnlocked();