From 78d8904f4a8eacca3689598eaeb34924e6238bcd Mon Sep 17 00:00:00 2001
From: yashlamba <yashlamba2000@gmail.com>
Date: Fri, 10 Nov 2023 10:50:06 +0100
Subject: [PATCH] legacy: deserializers: fix notes type -> id in metadata

---
 site/tests/conftest.py                           | 6 +++---
 site/zenodo_rdm/legacy/deserializers/metadata.py | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/site/tests/conftest.py b/site/tests/conftest.py
index 64e6d19f..ff0285ab 100644
--- a/site/tests/conftest.py
+++ b/site/tests/conftest.py
@@ -613,9 +613,9 @@ def description_type_v(app, description_type):
     vocab = vocabulary_service.create(
         system_identity,
         {
-            "id": "other",
-            "title": {"en": "Other"},
-            "props": {"datacite": "Other"},
+            "id": "notes",
+            "title": {"en": "Notes"},
+            "props": {"datacite": "Notes"},
             "type": "descriptiontypes",
         },
     )
diff --git a/site/zenodo_rdm/legacy/deserializers/metadata.py b/site/zenodo_rdm/legacy/deserializers/metadata.py
index 23cbec0d..871b22ae 100644
--- a/site/zenodo_rdm/legacy/deserializers/metadata.py
+++ b/site/zenodo_rdm/legacy/deserializers/metadata.py
@@ -269,7 +269,7 @@ def load_additional_descriptions(self, result, original, **kwargs):
         notes = original.get("notes")
         if notes:
             rdm_additional_descriptions.append(
-                {"description": notes, "type": {"id": "other"}}
+                {"description": notes, "type": {"id": "notes"}}
             )
 
         method = original.get("method")