Add custom control plane for third-party device vendors #2438
+1,020
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-henry
requested review from
laduke,
rcoder,
glimberg and
adamierymenko
glimberg
reviewed
Feb 26, 2025
Comment on lines
+28
to
+39
|
|
||
| #include <stdint.h> | ||
|
|
||
| #if UINTPTR_MAX == 0xffFFffFF | ||
| // 32-bit platform | ||
| template <typename Value_ = uint32_t> | ||
| #elif UINTPTR_MAX == 0xffFFffFFffFFffFF | ||
| // 64-bit platform | ||
| template <typename Value_ = uint64_t> | ||
| #else | ||
| #error Unknown platform - does not look either like 32-bit or 64-bit | ||
| #endif |
There was a problem hiding this comment.
So I've seen these changes in a couple of places in the prometheus imports. Nothing too horrible, for sure, but I wonder if it might be better to have these in a wrapper header just so that we don't have to modify the external stuff.
For instance, we create a <ztcounter.h> that includes this block of code, and then #include's the prometheus counter.h.
Just a thought
|
httpcpplib might need updating to fix this issue: only mentioning it because the change will get reverted if when copy in a new version of the lib |
|
Should probably add an Action that at the very least builds this configuration for PRs just to make sure it's in a state that compiles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides third-party device vendors the ability to manage ZeroTier without exposing the typical HTTPS control plane on
localhost. It can be enabled at compile-time viaZT_EXTOSDEP=1.There are minor changes to our dependencies which is not ideal but since the changes are so minor and it is so unlikely that they will change again I feel it is acceptable.