New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade: Do not allow passing wrong upgrade_plans #625

Open

ashcherbakov opened this issue Jan 17, 2025 · 0 comments

Milestone

Contributor

ashcherbakov commented Jan 17, 2025

The Issue to solve:

UpgradeProposal with incorrect upgrade_plan is sent and approved (incorrect means it doesn't match the constant from app.go)
Upgrade starts, and as upgrade_plan is wrong, the dcld cannot start

How to solve:

Add validation to UpgradeProposal handler: if upgrade_plan isn't present in app.go - validation error, and the upgrade shouldn't be scheduled

ashcherbakov added this to the v1.5: DCL 1.5 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment