Skip to content
This repository has been archived by the owner on Feb 7, 2025. It is now read-only.

revert(client): Remove use of unused TLS Server Name Indication #101

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

0x676e67
Copy link
Owner

@0x676e67 0x676e67 commented Aug 8, 2024

Summary by CodeRabbit

  • New Features

    • Simplified client configuration by removing TLS Server Name Indication (SNI) support.
  • Bug Fixes

    • Eliminated unnecessary complexity in the ClientBuilder API related to TLS configurations.

Copy link

coderabbitai bot commented Aug 8, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent changes involve the removal of the tls_sni field and its associated functionalities from both the Config struct and the ClientBuilder implementation. This simplification indicates a shift away from supporting TLS Server Name Indication (SNI), streamlining the client configuration process and its relevant methods.

Changes

Files Change Summary
src/async_impl/client.rs Removed tls_sni field from Config struct and tls_sni method from ClientBuilder. Debug output related to tls_sni removed.
src/blocking/client.rs Removed tls_sni method from ClientBuilder.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ClientBuilder
    participant Config

    User->>ClientBuilder: Set configuration
    ClientBuilder->>Config: Build with settings
    Config-->>User: Return Client
Loading

Poem

🐰 In the meadow where rabbits play,
TLS SNI has hopped away.
With a jump and a cheer,
Our config is clear,
Simplified paths for a brighter day! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@0x676e67 0x676e67 merged commit 1941380 into main Aug 8, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant