feat(proxy): Use instead of for reading proxy settings on Windows

[0x676e67]

ref: seanmonstar/reqwest#2380

Summary by CodeRabbit

• New Features
  • Updated to a new library for Windows registry access, improving functionality and compatibility.
• Improvements
  • Simplified access to Windows registry values, enhancing code clarity and type safety.
  • Removed platform-specific compilation directives for a more unified codebase across platforms.

[coderabbitai]

Walkthrough

The changes in this update primarily focus on modifying the Rust project's handling of Windows registry access. The Cargo.toml file reflects a shift from the winreg crate to windows-registry, suggesting enhanced functionality. In the source code, the get_from_platform_impl function has been simplified, using the new library for registry operations, which improves code clarity and type safety while maintaining the same functionality for proxy configuration retrieval.

Changes

File	Change Summary
Cargo.toml	Updated Windows dependency from winreg = "0.52.0" to windows-registry = "0.2".
src/proxy.rs	Replaced winreg crate usage with windows_registry, simplifying access to registry values. Removed conditional compilation for Windows.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant WindowsRegistry as Windows Registry Module
    App->>WindowsRegistry: Check Proxy Configuration
    WindowsRegistry-->>App: Return Proxy Enable Status
    App->>WindowsRegistry: Get Proxy Server Address
    WindowsRegistry-->>App: Return Proxy Server Address

Loading

Poem

🐇 In the world of code where rabbits play,
We've swapped some crates to brighten the day.
With registry changes, our logic's refined,
Now clearer and cleaner, more joyfully aligned.
Hopping through functions with ease and with glee,
Celebrating the changes, just wait and see! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e300a2d and 9179398.

Files selected for processing (2)

• Cargo.toml (1 hunks)
• src/proxy.rs (2 hunks)

Additional comments not posted (2)

Cargo.toml (1)

159-159: Dependency Update: Shift to windows-registry.

The dependency for Windows has been updated from winreg = "0.52.0" to windows-registry = "0.2". This change likely aims to leverage enhanced functionality or compatibility provided by the new library.

src/proxy.rs (1)

921-925: Improved Type Safety and Clarity in Registry Access.

The get_from_platform_impl function now uses the windows_registry module with get_u32 and get_string methods, enhancing type safety and clarity while maintaining the original functionality.

To ensure correctness, verify the function usage across the codebase.