Skip to content
This repository has been archived by the owner on Feb 7, 2025. It is now read-only.

fix(client): Fix http version setting order #120

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix(client): Fix http version setting order #120

merged 1 commit into from
Aug 15, 2024

Conversation

0x676e67
Copy link
Owner

@0x676e67 0x676e67 commented Aug 15, 2024

Summary by CodeRabbit

  • New Features

    • Removed default support for HTTP/2, requiring manual enabling for clients that need it.
    • Added a new optional dependency (typed-builder) for improved configuration management in the boring-tls context.
  • Bug Fixes

    • Streamlined client configuration by removing deprecated HTTP/2 settings, enhancing overall usability.
  • Documentation

    • Updated the conditions for exporting certain types from the hyper module to simplify usage requirements.
  • Chores

    • Cleaned up codebase by removing conditional compilation flags related to HTTP/2, focusing on HTTP/1.1 defaults.

Copy link

coderabbitai bot commented Aug 15, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent changes primarily focus on the removal of HTTP/2 support from the package, simplifying the default feature set. Dependencies related to HTTP/2 were eliminated, and configurations were streamlined to prioritize HTTP/1.1. Additional optional dependencies were introduced, enhancing flexibility for developers while maintaining extensibility. Overall, these modifications reflect a significant shift in the project's approach to HTTP handling and client configuration.

Changes

Files Change Summary
Cargo.toml Removed http2 feature and dependency; added typed-builder under boring-tls.
src/async_impl/client.rs Removed HTTP/2 related functionality and configuration; simplified client setup to HTTP/1.1.
src/blocking/client.rs Removed HTTP/2 configurations; methods now rely on boring-tls feature instead.
src/lib.rs Simplified exports from hyper by removing dependency on http2 for certain types.
src/tls/builder.rs Streamlined HTTP version handling; removed conditional checks for HTTP/2, assuming it's available.

Sequence Diagram(s)

sequenceDiagram
    participant Client as Client
    participant Server as Server
    Client->>Server: Sends HTTP request (HTTP/1.1)
    Server-->>Client: Responds with HTTP response
    Note over Client, Server: HTTP/2 support removed; only HTTP/1.1 is used.
Loading

Poem

🐰 In a code garden, changes bloom,
HTTP/2, we bid adieu!
With typed-builder, new paths we weave,
Simplicity reigns, we truly believe!
Hopping along with joy and cheer,
For HTTP/1.1, we hold dear! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@0x676e67 0x676e67 merged commit 60f3521 into main Aug 15, 2024
1 check passed
@0x676e67 0x676e67 deleted the fix branch August 15, 2024 00:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant