Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running workflow from notebooks and several other improvements #31

Merged
merged 75 commits into from
Jan 18, 2024

Conversation

franioli
Copy link
Collaborator

@franioli franioli commented Jan 17, 2024

Configuration managment

  • Configuration management: created new Config class that can be called with a dictionary containing the CLI parameters to parse it and setting up all the configurations. Now you can run the processing from a notebook by creating a new instance of this Config class.
  • Updated input arguments in CLI for defining the paths needed for the processing. You can either define the project directory (that must contains a folder names "images") in which the results will be stores (so images and results are all in a single directory) or use the old approach defining the path to the image directory and the path to the output directory (see python main.py -h).

Back-end

  • speedup matching_lowres preselection: now the extraction and matching are carried out in two steps (without repeating extraction for every pair).
  • Small updates in PairsGenerator class and its methods
  • Updated the interpolation function when doing image down/upsampling before extraction: replace laplacian pyramids with cv2.area for downsampling and linear or bicubic for upsampling.
  • Added function to automatically create a Metashape project from a pycolmap reconstruction and run BA (it is still in the scripts folder, it is not yet integrated in Deep-Image-Matching).
  • Updated to pycolmap 0.5.0 and updated the reconstruction module to adapt to it.
  • Updated LightGlue to the last version to fix code crash when no keypoints are passed to the matcher (92)
  • Add visualization methods for extractors and matchers. Now the keypoints and the matched features are automatically saved in the debug folder within the output directory, if the parameter -Vis passed to the parser.
  • Use threading for saving features in h5 file and figures to disk
  • Code cleaning in extractors and matchers modules
  • Removed heavy datasets from repository. They are temporarly uploaded here.

@franioli franioli requested a review from lcmrl January 17, 2024 17:55
@franioli franioli merged commit d71f39f into master Jan 18, 2024
@franioli franioli deleted the notebooks branch January 18, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant