Skip to content
This repository has been archived by the owner on Mar 7, 2022. It is now read-only.

Commit

Permalink
encodeURIComponent for email body thanks to @overovermind
Browse files Browse the repository at this point in the history
  • Loading branch information
45kb committed May 2, 2017
1 parent ee70c9c commit 2327c95
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion bower.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "angular-socialshare",
"version": "2.3.7",
"version": "2.3.8",
"description": "A social media url and content share module for angularjs.",
"authors": [
"Filippo Oretti <[email protected]",
Expand Down
6 changes: 3 additions & 3 deletions dist/angular-socialshare.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
/*
* angular-socialshare
* 2.3.7
* 2.3.8
*
* A social media url and content share module for angularjs.
* http://720kb.github.io/angular-socialshare
*
* MIT license
* Sat Feb 18 2017
* Tue May 02 2017
*/
/*global angular*/
/*eslint no-loop-func:0, func-names:0*/
Expand Down Expand Up @@ -536,7 +536,7 @@

if (attrs.socialshareBody) {

urlString += 'body=' + attrs.socialshareBody;
urlString += 'body=' + encodeURIComponent(attrs.socialshareBody);
}

if (attrs.socialshareSubject) {
Expand Down
Loading

2 comments on commit 2327c95

@jdaoudou
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

First I whant to thanks for library, we are happy to use your service.
Currently we use it for a website with more than 100,000 users, with excellent result.

However, I turn to you today because the last update posed a problem.
The fix 2.3.8 for encodeURIComponent for email body is blocking for us.
Indeed, we had realized on our side a similar modification directly in the code.

The application of this patch two time is therefore problematic.
On our side, we have no way of intervening before 29/06.
Do you think we can provide a temporary solution to avoid this blocking ?
For example manual activation/deactivation of this functionality

I thank you in advance,
Best regards,

Joakim D

@45kb
Copy link
Member Author

@45kb 45kb commented on 2327c95 May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdaoudou Hi, thanks we're glad to hear that you found this useful :)

Actually i see one simple solution to your problem.
Why not downgrade to v2.3.7 if you're having problems with v2.3.8 :) ?

Next time please open an issue for such questions, otherwise will be difficult to find you :)

Thanks!

Please sign in to comment.