Merge pull request #160 from shaibo10/sms-fix

Sms fix: text that contains '%' wont crash sms share
720kb · Sep 29, 2016 · c36e95e · c36e95e
2 parents a160062 + 39206c7
commit c36e95e
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 6 deletions.
diff --git a/dist/angular-socialshare.js b/dist/angular-socialshare.js
@@ -6,7 +6,7 @@
  * http://720kb.github.io/angular-socialshare
  * 
  * MIT license
- * Tue Sep 27 2016
+ * Wed Sep 28 2016
  */
 /*global angular*/
 /*eslint no-loop-func:0, func-names:0*/
@@ -263,6 +263,7 @@
       {
         'provider': 'sms',
         'conf': {
+          'url': '',
           'text': '',
           'to': '',
           'trigger': 'click'
@@ -765,7 +766,12 @@
     }
     ,manageSmsShare = function smsShare($window, attrs, element) {
 
-      var body = encodeURIComponent(attrs.socialshareText)
+      if(attrs.socialshareText.indexOf('%')>=0)
+      {
+        $log.warn('sending sms text with "%" sign is not supported');
+      }
+
+      var body = encodeURIComponent(attrs.socialshareText.replace('%','')) + ' - ' + encodeURIComponent(attrs.socialshareUrl)
         , toPhoneNumber = attrs.socialshareTo || ''
         , urlString = 'sms:' + toPhoneNumber + '?&body=' + body;
 

diff --git a/dist/angular-socialshare.js.map b/dist/angular-socialshare.js.map