Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CPU check and CI #15

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Add a CPU check and CI #15

merged 1 commit into from
Jan 9, 2025

Conversation

tengyifei
Copy link
Collaborator

@tengyifei tengyifei commented Jan 8, 2025

Similar to #13, we also add a CPU github action. This action will run pytest on the repo.

Currently there is only one test, which is the Llama test in torch_xla_models.

In order to run the test today, we need a HF_TOKEN. I created a personal read only token and
#14 tracks avoiding the need for HF_TOKEN, after which I'll need to remember to invalidate the token.

This should fix #8

@tengyifei tengyifei force-pushed the cpu-test-ci branch 4 times, most recently from 55d7a79 to d93f261 Compare January 9, 2025 00:07
Similar to #13, we
also add a CPU github action. This action will run `pytest` on the repo.

Currently there is only one test, which is the Llama test in
torch_xla_models.

In order to run the test today, we need a HF_TOKEN. I created a personal
read only token and
#14 tracks avoiding
the need for HF_TOKEN, after which I'll need to remember to invalidate
the token.
- name: Run PyTest
run: |
# TODO(https://github.com/AI-Hypercomputer/torchprime/issues/14): Remove and burn the token.
export HF_TOKEN=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
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think github also has a way to store secrets. We do that for pytorch/xla repo but probably not worth spending time on given that we are going to remove this soon.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

@tengyifei tengyifei merged commit 90e1f77 into main Jan 9, 2025
6 checks passed
qihqi pushed a commit that referenced this pull request Jan 10, 2025
Similar to #13, we
also add a CPU github action. This action will run `pytest` on the repo.

Currently there is only one test, which is the Llama test in
torch_xla_models.

In order to run the test today, we need a HF_TOKEN. I created a personal
read only token and
#14 tracks avoiding
the need for HF_TOKEN, after which I'll need to remember to invalidate
the token.
qihqi pushed a commit that referenced this pull request Jan 13, 2025
Similar to #13, we
also add a CPU github action. This action will run `pytest` on the repo.

Currently there is only one test, which is the Llama test in
torch_xla_models.

In order to run the test today, we need a HF_TOKEN. I created a personal
read only token and
#14 tracks avoiding
the need for HF_TOKEN, after which I'll need to remember to invalidate
the token.
@tengyifei tengyifei deleted the cpu-test-ci branch January 13, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add presubmit and CI checks to torchprime
2 participants