Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCC 10.3: Wstringop-overflow in FabConv #2660

Closed
wants to merge 1 commit into from
Closed

GCC 10.3: Wstringop-overflow in FabConv #2660

wants to merge 1 commit into from

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Mar 16, 2022 •
edited
Loading

Summary

Spotted a buffer overflow when building amrvis with GCC 10.3.

Additional background

See AMReX-Codes/Amrvis#17
See ECP-WarpX/WarpX#2978

Checklist

The proposed changes:

  • fix a bug or incorrect behavior in AMReX
  • add new capabilities to AMReX
  • changes answers in the test suite to more than roundoff level
  • are likely to significantly affect the results of downstream AMReX users
  • include documentation in the code and/or rst files, if appropriate

@ax3l
GCC 10.3: Wstringop-overflow
5cd1f60 
Spotted a couple of buffer overflows when building amrvis with
GCC 10.3.
@ax3l ax3l requested a review from WeiqunZhang March 17, 2022 17:48
@ax3l ax3l mentioned this pull request Mar 17, 2022
Open
1 task
@ax3l ax3l changed the title GCC 10.3: Wstringop-overflow GCC 10.3: Wstringop-overflow in FabConv Mar 18, 2022
@ax3l
Copy link
Member Author

ax3l commented Mar 18, 2022

We see the same buffer overflow in WarpX @WeiqunZhang: ECP-WarpX/WarpX#2978

@ax3l ax3l mentioned this pull request Mar 18, 2022
Merged
@ax3l
Copy link
Member Author

ax3l commented May 4, 2022

transferred in an issue: #2750

help wanted :)

@ax3l ax3l closed this May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeiqunZhang WeiqunZhang Awaiting requested review from WeiqunZhang

Assignees

@WeiqunZhang WeiqunZhang

Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ax3l @WeiqunZhang