Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix seg demo script #542

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix seg demo script #542

merged 1 commit into from
Nov 6, 2024

Conversation

kevin-thankyou-lin
Copy link
Contributor

@kevin-thankyou-lin kevin-thankyou-lin commented Nov 4, 2024 •
edited
Loading

What this does

Fix seg demo script. For some machines, using the default renderer=mjviewer leads to implausible segmentations. Updating to renderer=mujoco appears to fix this issue for some machines.

How it was tested

Explain/show how you tested your changes.

python robosuite/demos/demo_segmentation.py

@kevin-thankyou-lin
Copy link
Contributor Author

@snasiriany bumping this PR review

snasiriany
snasiriany approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@snasiriany snasiriany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snasiriany snasiriany merged commit 7d420bc into master Nov 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snasiriany snasiriany snasiriany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin-thankyou-lin @snasiriany