Update demo docs w/ teleop usage info #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snasiriany
requested changes
Nov 4, 2024
There was a problem hiding this comment.
The rest of the docs pertaining to this demo_device_control.py need to be updated:
- example commands have
--controller oscwhich is incorrect - it talks about ik vs osc ("user inputs with ik’s rotations are always taken relative to eef coordinate frame, whereas user inputs with osc’s rotations are taken relative to global frame (i.e., static / camera frame of reference).") which at this point is out of date info and needs to be removed I think.
these are at least the parts I found. Can you please update the PR with all of the changes needed for this section?
|
@snasiriany updated |
snasiriany
requested changes
Nov 4, 2024
There was a problem hiding this comment.
@kevin-thankyou-lin there's a section slightly above that needs to be updated: "The commands are mapped to joint velocities through an inverse kinematics solver from Bullet physics."
|
@snasiriany can you merge this? |
snasiriany
approved these changes
Nov 6, 2024
|
@kevin-thankyou-lin done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update demo docs w/ teleop usage info