Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix joints and actuators #575

Merged

Conversation

squarefk
Copy link

@squarefk squarefk commented Nov 22, 2024

Fix two minor issues:

  1. Address the issue where some joints remain in after removing joints from the XML.
  2. Ensure proper handling when joint_id and actuator_id have different orders, and utilize the gear attribute from the actuator.

@squarefk
Copy link
Author

The relevant section in the xml file looks like this:
image

@squarefk squarefk force-pushed the fix-joints-and-actuators branch from b076e8a to 2445387 Compare November 22, 2024 07:22
@kevin-thankyou-lin
Copy link
Contributor

Thanks @squarefk! Double checking you've tested the changes with the GR1 too?

@squarefk
Copy link
Author

@kevin-thankyou-lin Yes, I have tested it. If no attribute is explicitly declared in the robot's XML file, the value read from MjModel.actuator_gear will default to 1.

Copy link
Contributor

@kevin-thankyou-lin kevin-thankyou-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kevin-thankyou-lin kevin-thankyou-lin merged commit a651720 into ARISE-Initiative:master Nov 26, 2024
2 checks passed
@kevin-thankyou-lin
Copy link
Contributor

thanks!

@squarefk squarefk deleted the fix-joints-and-actuators branch November 26, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants