Add all manipulators to demo_random_action by default #618
Conversation
When choosing GR1 the robot falls. I am assuming this is expected. Otherwise LGTM |
yes, that's expected |
|
Added all robots in this link
|
kevin-thankyou-lin
changed the title
There was a problem hiding this comment.
When running with the spot it tends to move and leave the arena. Not sure if this is a big deal, but if it is worth changing, it should not be too hard right - I imagine you can just remove mobile control for this script?
Another thing I noticed is that when choosing a TwoArmEnv not all robots are given as an option.
Otherwise LGTM
|
That's what I found too. Better to freeze the base.
…On Tue, Jan 14, 2025 at 3:45 PM Abhiram824 ***@***.***> wrote:
***@***.**** requested changes on this pull request.
When running with the spot it tends to move and leave the arena. Not sure
if this is a big deal, but if it is worth changing, it should not be too
hard right - I imagine you can just remove mobile control for this script?
Otherwise LGTM
—
Reply to this email directly, view it on GitHub
<#618 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJDEAMCSN5VNN2LAABJM6T2KWOSXAVCNFSM6AAAAABU7CMKH6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNJRGI2TSMBYGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
sounds good; I'll leave the change to @Abhiram824 since this PR needs another approval |
…r more robots in twoarm envs as well as the option for a single robot in the twoarm env
|
I changed spot to be the floating base version because the other version falls down, but we can change things back |
|
Changes look good to me - you'll need to approve since I created the PR @Abhiram824 |
What this does
Add all manipulators in https://robosuite.ai/docs/modules/robots.html#manipulators to demo_random_action by default
How to test
python robosuite/demos/demo_random_action.py, then selectGR1option