Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pot with handles when pot is rectangle #628

Merged

Conversation

xieleo5
Copy link
Contributor

@xieleo5 xieleo5 commented Jan 24, 2025

The current pot_with_handles object will result in a wrong shape when size[0] != size[1] One line change can fix this.

@xieleo5
Copy link
Contributor Author

xieleo5 commented Jan 24, 2025

Code to test

pot = PotWithHandlesObject(
            name="pot",
            body_half_size=[0.16, 0.20, 0.05],
            handle_radius=0.01,
            handle_length=0.06,
            handle_width=0.14,
)

Expected behavior, return a rectangle tray with handles.

Before
image
After
image

@kevin-thankyou-lin kevin-thankyou-lin merged commit 3f92519 into ARISE-Initiative:master Jan 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants