Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: windows arm build #80

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

0xbrayo
Copy link
Member

@0xbrayo 0xbrayo commented Feb 15, 2025

Important

Add Windows ARM64 build support to build.yml and release.yml workflows.

  • Workflows:
    • Add Windows ARM64 build support in build.yml and release.yml.
    • Add platform entry windows-latest with --target aarch64-pc-windows-msvc argument for Windows ARM64.

This description was created by Ellipsis for ff526a9. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ff526a9 in 1 minute and 16 seconds

More details
  • Looked at 26 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. .github/workflows/build.yml:21
  • Draft comment:
    Consider using a unique identifier (e.g. 'windows-arm64') for the ARM build entry to differentiate it from the standard Windows build.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 30% vs. threshold = 50%
    The current setup uses the same platform identifier 'windows-latest' twice, but differentiates the ARM build using the args parameter. While using a unique identifier might make the configuration more readable, the current setup is functionally correct since GitHub Actions matrices can handle this pattern. The args parameter already clearly identifies the ARM target.
    The current setup might actually be intentional to ensure both builds use the same Windows runner environment. A different identifier might imply a different runner type.
    While the suggestion might improve readability, it's not clearly incorrect or problematic as is, and the current approach might be deliberately chosen to ensure consistent runner environments.
    This comment should be deleted as it suggests a change that isn't clearly necessary or beneficial, and the current implementation is functionally correct.
2. .github/workflows/release.yml:22
  • Draft comment:
    Consider using a unique identifier (e.g. 'windows-arm64') for the ARM build entry to avoid confusion with standard Windows builds.
  • Reason this comment was not posted:
    Marked as duplicate.
3. .github/workflows/build.yml:21
  • Draft comment:
    Consider adding an explicit identifier (e.g. an 'arch' field) in the matrix for Windows ARM64 to differentiate it from the default 'windows-latest' entry.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
4. .github/workflows/release.yml:21
  • Draft comment:
    Consider differentiating the Windows ARM64 entry (e.g. by adding an 'arch' field) to clarify its purpose versus the default Windows build.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None

Workflow ID: wflow_OwhaDZWI5YgC47KU


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant