Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update upload-artifact action to version 4 #641

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Conversation

ErikBjare
Copy link
Member

@ErikBjare ErikBjare commented Feb 21, 2025

Important

Update upload-artifact action to major version v4 in nodejs.yml for consistency across jobs.

  • GitHub Actions:
    • Update upload-artifact action from v4.3.6 to v4 in nodejs.yml.
    • Affects Upload build steps in build-webpack and build-vite jobs.
    • Affects Upload logs step in test job.
    • Affects Upload screenshots step in test job.

This description was created by Ellipsis for 710fa62. It will automatically update as commits are pushed.

@ErikBjare ErikBjare merged commit 8ec401c into master Feb 21, 2025
6 of 7 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 710fa62 in 50 seconds

More details
  • Looked at 32 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 7 drafted comments based on config settings.
1. .github/workflows/nodejs.yml:32
  • Draft comment:
    Using unpinned v4 for upload-artifact may fetch unexpected updates. Consider pinning the patch version.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
2. .github/workflows/nodejs.yml:60
  • Draft comment:
    Consider pinning upload-artifact to a specific patch version instead of 'v4' to ensure consistent behavior.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
3. .github/workflows/nodejs.yml:194
  • Draft comment:
    Unpinned version in logs upload step might lead to unexpected updates. Pin a specific patch version if stability is required.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
4. .github/workflows/nodejs.yml:32
  • Draft comment:
    Updated upload-artifact version to 'v4'. Consider pinning to a specific minor release (e.g., v4.3.x) to avoid unintentional breaking changes.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None
5. .github/workflows/nodejs.yml:60
  • Draft comment:
    Updated upload-artifact version to 'v4'. Consider pinning to a specific minor release to ensure stability.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None
6. .github/workflows/nodejs.yml:194
  • Draft comment:
    Updated upload-artifact version and modified artifact name to include matrix values. Verify downstream consumers use the new name.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None
7. .github/workflows/nodejs.yml:175
  • Draft comment:
    The version for the 'actions/upload-artifact' in the 'Upload screenshots' step is still set to v4.3.6, while the other occurrences have been updated to v4. For consistency, please update it to v4.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_WFfdmQPO5RyHAhMI


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.98%. Comparing base (8679b69) to head (710fa62).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #641   +/-   ##
=======================================
  Coverage   25.98%   25.98%           
=======================================
  Files          27       27           
  Lines        1643     1643           
  Branches      292      292           
=======================================
  Hits          427      427           
  Misses       1157     1157           
  Partials       59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants