Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix tests #642

Merged
merged 1 commit into from
Feb 21, 2025
Merged

fix: fix tests #642

merged 1 commit into from
Feb 21, 2025

Conversation

BelKed
Copy link
Contributor

@BelKed BelKed commented Feb 21, 2025

Important

Enhance snapshot tests to include processing for browser titles in queries.test.node.js.snap.

  • Tests:
    • In queries.test.node.js.snap, added processing for browser_titles by merging, sorting, and limiting events.
    • Updated snapshot to include titles in the RETURN object under browser.

This description was created by Ellipsis for 6ff207e. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6ff207e in 34 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. test/unit/__snapshots__/queries.test.node.js.snap:30
  • Draft comment:
    Ensure consistent snapshot update for browser_titles transformations.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is asking the author to ensure something, which violates the rule against asking the author to ensure behavior is intended or tested. It doesn't provide a specific suggestion or point out a specific issue.
2. test/unit/__snapshots__/queries.test.node.js.snap:42
  • Draft comment:
    Include browser_titles in the browser return object for snapshot consistency.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment seems to be purely informative, as it is stating what is included in the return object. It does not provide a suggestion, ask for confirmation, or point out a potential issue. Therefore, it should be removed according to the rules.
3. test/unit/__snapshots__/queries.test.node.js.snap:30
  • Draft comment:
    Added browser_titles chain (merge, sort, limit). Verify this chain matches your test logic.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
4. test/unit/__snapshots__/queries.test.node.js.snap:45
  • Draft comment:
    New 'titles' property added to RETURN object. Confirm consistency with snapshot updates.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None

Workflow ID: wflow_uZ70MnmMFircaTkF


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.15%. Comparing base (606112e) to head (6ff207e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #642      +/-   ##
==========================================
+ Coverage   25.92%   26.15%   +0.22%     
==========================================
  Files          28       28              
  Lines        1647     1652       +5     
  Branches      293      281      -12     
==========================================
+ Hits          427      432       +5     
- Misses       1161     1194      +33     
+ Partials       59       26      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErikBjare ErikBjare merged commit 53cbaaa into ActivityWatch:master Feb 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants