Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing bucket ID when editing events #644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BelKed
Copy link
Contributor

@BelKed BelKed commented Feb 21, 2025

Tries to solve #576


Important

Fixes missing bucket ID when editing events in VisTimeline.vue by correcting bucketId assignment in onSelect method.

  • Bug Fix:
    • Fixes missing bucket ID when editing events in onSelect method of VisTimeline.vue.
    • Corrects bucketId assignment to use this.items[properties.items[0]].group instead of searching through groups.

This description was created by Ellipsis for 543393b. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 543393b in 54 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. src/visualizations/VisTimeline.vue:167
  • Draft comment:
    Good fix: bucketId is now directly retrieved from items, ensuring the correct bucket ID is used for API calls.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is purely informative, as it simply states what the code is doing without providing any suggestions, questions, or potential issues. It does not align with the rules for useful comments.
2. src/visualizations/VisTimeline.vue:167
  • Draft comment:
    Using the item’s 'group' property directly to retrieve the bucket ID is cleaner and avoids the pitfall of relying on group content—which can be empty if row labels are hidden. Confirm that the 'group' field in items always holds the correct bucket ID for $aw.getEvent().
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
3. src/visualizations/VisTimeline.vue:170
  • Draft comment:
    Typo in comment: "ensure if's not cut-off by the query range" should likely be "ensure it's not cut off by the query range".
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_CHHOcBViI8bEGPS3


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.76%. Comparing base (1860f15) to head (543393b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
+ Coverage   26.15%   26.76%   +0.61%     
==========================================
  Files          28       28              
  Lines        1652     1655       +3     
  Branches      289      280       -9     
==========================================
+ Hits          432      443      +11     
- Misses       1161     1186      +25     
+ Partials       59       26      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BelKed BelKed marked this pull request as draft February 21, 2025 12:17
@BelKed BelKed marked this pull request as ready for review February 21, 2025 12:22
@BelKed
Copy link
Contributor Author

BelKed commented Feb 21, 2025

Fixes only for Raw Data; Search and Query works a bit different :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant