[trello.com/c/ciHCs1De]: fix not updating row height after balance change #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBenua
requested review from
just-software-dev,
StanislavDevIOS and
vovameister
ChrisBenua
commented
Jan 8, 2025
ChrisBenua
force-pushed
the
dev/trello.com/c/ciHCs1De
branch
from
67e4d39 to
214bd51
Compare
| let height = row.value?.fiat != nil ? BalanceTableViewCell.fullHeight : BalanceTableViewCell.compactHeight | ||
|
|
||
| cell.height = { height } | ||
| cell.titleLabel.text = BaseRows.balance.localized |
There was a problem hiding this comment.
Why so much of code is removed?
There was a problem hiding this comment.
It was dead code, it never executes. Because line 158 overwrite cellUpdateCallback variable inside Eureka
ChrisBenua
force-pushed
the
dev/trello.com/c/ciHCs1De
branch
from
214bd51 to
55708b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.cellUpdatefrom 141 line was overwritten in 158 line. So, code from line 141 is useless, we can delete it. But it was not the only reason caused bug.Now height of balance cell is calculated based on current row ViewModel:
$0.cell.height = { row.value?.fiat != nil ? BalanceTableViewCell.fullHeight : BalanceTableViewCell.compactHeight }.According to docs, to update cell height (not the content), we should call
updateCelljust beforereloadcall. Withoutreloadcall height of cell will not be updated