[trello.com/c/AvS5QpYb]: fix error toast for unavailable node while refreshing the content #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…льшой рефакторинг. Отображение ошибки текущей выбранной ноды
|
If active coin nodes are good, pick up other coin where nodes are not available. E.g, ADM is chosen, but there are active nodes, show ~“No BTC nodes” if BTC nodes are not available. — not passed |
|
Use English only in pull requests and commits |
Adamant/Modules/Account/AccountViewController/AccountViewController.swift
Outdated
Show resolved
Hide resolved
Adamant/Modules/Account/AccountViewController/AccountViewController.swift
Show resolved
Hide resolved
Adamant/Modules/Account/AccountViewController/AccountViewController.swift
Outdated
Show resolved
Hide resolved
Adamant/Modules/Account/AccountViewController/AccountViewController+Form.swift
Show resolved
Hide resolved
VeretennikovSV
changed the title
ChrisBenua
reviewed
Jan 10, 2025
Adamant/Modules/Account/AccountViewController/AccountViewController+Form.swift
Show resolved
Hide resolved
ChrisBenua
reviewed
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem with the wrong logic of handling the unavailable nodes.
It was handled the first node in the list of unavailable ones and presented an error about this node no matter which node currently selected.
I've simply added some logic to compare the current selected wallet and its network system with unavailable nodes. And only if its system appeared in the list of unavailable nodes toast should be presented on a screen
https://trello.com/c/AvS5QpYb/738-bug-warning-window-no-active-nodes