Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): add preview template for url/resources #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kaf-lamed-beyt
Copy link

@kaf-lamed-beyt kaf-lamed-beyt commented Dec 20, 2024

addresses #16

@elpiel, I don't think metatags.io have a public API, so i found an alternative. Kindly review and let me know what you think.

image

@elpiel
Copy link
Member

elpiel commented Dec 20, 2024

Thank you for your pr!
I think you are on the right path, since it's a static website and it is relying on external service (even if it's only once to build the site) I'd like to keep this inside the project itself.

What we should do is add a macro/function and a short code (for visualising the data).
It's straight forward to fetch the website and extract all the tags for social media.

The most challenging part would be to figure out what tags exist and what not and what is the type of social preview the website defines.
This would, of course, translate to more than 1 design but yours is a pretty good starting point.

Ps: this is a new feature btw

@kaf-lamed-beyt
Copy link
Author

hi @elpiel, sorry for just getting back now.

i tried going with what you suggested and ran into a couple of issues, I share them with you later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants