-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/websocket everywhere #43
Open
316k
wants to merge
27
commits into
Agneli:master
Choose a base branch
from
316k:feature/websocket-everywhere
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though it is not used yet, send and refresh functions both work. The server doesn't implement it yet.
When a websocket connection is lost, the app is reloaded
The same actions can now be performed via HTTP and WebSocket requests
Not fully tested
Not fully tested
…k/linux-remote-control into feature/websocket-everywhere Conflicts: opt/lrc-client/js/connection/connection.js opt/lrc-client/js/connection/http.js opt/lrc-client/js/connection/websocket.js opt/lrc-client/js/js.js opt/lrc-server/configuration.js
@316k, send me your email please. |
I think it's on the git log, but here it is : 316k (at) legtux / org |
… into feature/websocket-everywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now choose which driver to use between HTTP and WebSocket. The server must have the same configuration as the client. The default configuration is WebSocket on port 3000.