Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(SwingSet): Improve config documentation, typing, and async function implementations #10538

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor(SwingSet): Improve config documentation, typing, and async function implementations #10538

wants to merge 2 commits into from
+129 −145

Conversation

gibson042
Copy link
Member

Description

  • Document new config parameters (defaultReapGCKrefs and vat-level neverReap/reapGCKrefs, plus node-specific nodeOptions)
  • Remove obsolete config parameters (vat-level name/metered/virtualObjectCacheSize)
  • Improve the accuracy of SwingSet config types in both JSDoc and Patterns
  • Simplify some async functions for better comprehensibility and interactive debugging (e.g., vats and bundles both require one of sourceSpec/bundleSpec/bundle, but the former additionally support creationOptions/parameters options while the latter do not)

Security Considerations

None known.

Scaling Considerations

n/a

Documentation Considerations

None in particular.

Testing Considerations

n/a

Upgrade Considerations

n/a

@gibson042 gibson042 requested review from warner and mhofman November 20, 2024 19:32
@gibson042 gibson042 requested a review from a team as a code owner November 20, 2024 19:32
@gibson042 gibson042 force-pushed the gibson-2024-11-swingset-types branch from 635e902 to 1275fae Compare January 30, 2025 15:50
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 30, 2025 •
edited
Loading

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1275fae
Status: ✅  Deploy successful!
Preview URL: https://b656490a.agoric-sdk.pages.dev
Branch Preview URL: https://gibson-2024-11-swingset-type.agoric-sdk.pages.dev

View logs

@gibson042 gibson042 requested a review from michaelfig January 30, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warner warner Awaiting requested review from warner

@mhofman mhofman Awaiting requested review from mhofman

@siarhei-agoric siarhei-agoric Awaiting requested review from siarhei-agoric

@michaelfig michaelfig Awaiting requested review from michaelfig

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gibson042