Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(SwingSet): Cleanup vatManagerFactory #10808

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gibson042
Copy link
Member

  • Warn on any use of setup or enableSetup that overrides type.
  • Improve error message detail.
  • Collapse together all typed vat factory invocations.

Description

  • Warn on any use of setup or enableSetup that overrides type.
  • Improve error message detail.
  • Collapse together all typed vat factory invocations.
  • Rename "vatManagerFactory" to the more precise "makeVatManager" (we don't have a convention for the former), and accordingly rename "makeVatManagerFactory" to "makeVatManagerMaker" (which is slightly more cumbersome but substantially more clear).

Security Considerations

n/a

Scaling Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

n/a

Upgrade Considerations

n/a

@gibson042 gibson042 requested a review from a team as a code owner January 7, 2025 03:26
@gibson042 gibson042 requested a review from AgoricTriage January 7, 2025 03:26
Copy link

cloudflare-workers-and-pages bot commented Jan 7, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0e0c154
Status: ✅  Deploy successful!
Preview URL: https://6232649c.agoric-sdk.pages.dev
Branch Preview URL: https://gibson-2025-01-cleanup-vat-l.agoric-sdk.pages.dev

View logs

* Warn on any use of `setup` or `enableSetup` that overrides `type`.
* Improve error message detail.
* Collapse together all typed vat factory invocations.
@gibson042 gibson042 force-pushed the gibson-2025-01-cleanup-vat-loader branch from d6df1e7 to 0e0c154 Compare January 30, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant