Follow-up fake vstorage blockHeight advancement #10959
Merged
+24
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
fe360e5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dd3573cd.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mhofman-fake-vstorage-blocks-sv6l.agoric-sdk.pages.dev |
gibson042
approved these changes
Feb 7, 2025
gibson042
reviewed
Feb 7, 2025
| @@ -266,21 +266,21 @@ test('makeFakeStorageKit sequence data', async t => { | |||
| 'manual-sequence grandchild setValue message', | |||
| ); | |||
| t.deepEqual(getValues(deepPath), ['baz', 'qux']); | |||
gibson042
reviewed
Feb 7, 2025
| @@ -184,14 +186,17 @@ export const makeFakeStorageKit = (rootPath, rootOptions) => { | |||
| } catch (_err) { | |||
| streamCell = undefined; | |||
| } | |||
| // StreamCells reset at block boundaries. | |||
| if (Number(streamCell?.blockHeight) !== currentBlockHeight) { | |||
There was a problem hiding this comment.
Suggested change
| if (Number(streamCell?.blockHeight) !== currentBlockHeight) { | |
| if (streamCell && Number(streamCell.blockHeight) !== currentBlockHeight) { |
There was a problem hiding this comment.
Oops, good thing the test I had updated caught that :p
mhofman
force-pushed
the
mhofman/fake-vstorage-blocks-2
branch
from
d79749f to
fe360e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #10933
Description
Forgot some test updates in the previous PR
Also it was on automerge so I couldn't include @gibson042 's review suggestion
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
Internal test hooks
Testing Considerations
Updated unit tests of fake storage
Upgrade Considerations
None