Update and refactor Python files #886
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hocheung-chromium
force-pushed
the
python
branch
3 times, most recently
from
9b60dce to
afdf068
Compare
hocheung-chromium
force-pushed
the
python
branch
from
afdf068 to
3dc865e
Compare
hocheung-chromium
force-pushed
the
python
branch
3 times, most recently
from
84999a5 to
6681bc0
Compare
hocheung-chromium
force-pushed
the
python
branch
from
6681bc0 to
d8d9345
Compare
1. Reformatted Python code using Microsoft's official VS Code extension Black Formatter. https://github.com/microsoft/vscode-black-formatter 2. Fixed an issue in `setup.py` where PGO files were not downloaded when no arguments were passed (i.e., when building the AVX version). 3. `clean.py` now better identifies and cleans up PGO files and output directories after compilation. 4. `make_portable_win.py` now supports copying the installer directly from the build output directory and renaming the portable archive according to Thorium's naming convention.
hocheung-chromium
force-pushed
the
python
branch
from
d8d9345 to
16ed965
Compare
|
PTAL :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
official VS Code extension Black Formatter.
https://github.com/microsoft/vscode-black-formatter
Fixed an issue in
setup.pywhere PGO fileswere not downloaded when no arguments were passed
(i.e., when building the AVX version).
clean.pynow better identifies and cleans upPGO files and output directories after
compilation.
make_portable_win.pynow supports copying theinstaller directly from the build output directory
and renaming the portable archive according to
Thorium's naming convention.