Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

268 Provide grb::set(Matrix out, Matrix mask, Matrix in) #314

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

268 Provide grb::set(Matrix out, Matrix mask, Matrix in) #314

wants to merge 9 commits into from

Conversation

aleksamilisavljevic
Copy link
Contributor

Closes #268

@aleksamilisavljevic aleksamilisavljevic linked an issue Feb 21, 2024 that may be closed by this pull request
Provide grb::set(Matrix out, Matrix mask, Matrix in) #268
Open
@aleksamilisavljevic aleksamilisavljevic changed the title 268 provide grbsetmatrix out matrix mask matrix in 268 Provide grb::set(Matrix out, Matrix mask, Matrix in) Feb 21, 2024
byjtew
byjtew requested changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@byjtew byjtew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, as for the unit-test, you could rely on the matrix factories that we have.
e.g: L masked by I should return I
L being a Lower triangular matrix
I being an identity matrix

include/graphblas/nonblocking/io.hpp Outdated Show resolved Hide resolved
include/graphblas/reference/io.hpp Outdated Show resolved Hide resolved
include/graphblas/reference/io.hpp Outdated Show resolved Hide resolved
include/graphblas/reference/io.hpp Show resolved Hide resolved
include/graphblas/reference/io.hpp Outdated Show resolved Hide resolved
include/graphblas/reference/io.hpp Outdated Show resolved Hide resolved
include/graphblas/reference/io.hpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byjtew byjtew byjtew requested changes

@anyzelman anyzelman Awaiting requested review from anyzelman

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide grb::set(Matrix out, Matrix mask, Matrix in)
2 participants
@aleksamilisavljevic @byjtew